Fix for issue #11 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a test for you, which is now failing. |
MaybeJustJames
requested changes
Dec 5, 2024
| @@ -551,10 +551,8 @@ recordInlinePropertyName = | |||
|
|
|||
| recordInlinePropertyNameString : P.Parser String | |||
| recordInlinePropertyNameString = | |||
| -- TODO allow numeric name | |||
There was a problem hiding this comment.
I would prefer you not remove TODO comments that your PR does not address.
| P.succeed () | ||
| |. P.chompWhile (U.neither3 U.isColon U.isComma U.isRecordEnd) | ||
| |. U.whitespace |
There was a problem hiding this comment.
This change is incorrect. Whitespace here should be ignored
| @@ -581,7 +579,7 @@ recordInlineString = | |||
| P.succeed () | |||
| |. P.chompWhile (U.neither U.isComma U.isRecordEnd) | |||
| |> P.getChompedString | |||
| |> P.map Ast.fromString | |||
| |> P.map (Ast.fromString << String.trim) | |||
There was a problem hiding this comment.
I don't really understand why you're doing this? I don't see how this addresses the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.
Checklist: