Carry explicit encoding context along as we encode values. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to correctly encode values with different indentation in lists and records. As a side-effect of this change, the way indentation is rendered has changed such that there are `indent - 1` spaces between multiline list markers and list elements now. I believe this is most consistent. This commit adds tests to ensure that encoding of records in lists (both inline and not inline) are correct. Closes #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to correctly encode values with different indentation in lists and records. As a side-effect of this change, the way indentation is rendered has changed such that there are
indent - 1spaces between multiline list markers and list elements now. I believe this is most consistent.This commit adds tests to ensure that encoding of records in lists (both inline and not inline) are correct.
Closes #29
Checklist: