f

MaxymVlasov · Feb 12, 2025 · 215cbb1 · 215cbb1
1 parent b985987
commit 215cbb1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -163,8 +163,8 @@ jobs:
         shell: bash
         run: |
           error_message="${{ steps.always-comment-missing-github-token.outputs.error }}"
-          expected_message="Resource not accessible by integration - \
-          https://docs.github.com/rest/issues/comments#create-an-issue-comment"
+          expected_message="To post scan results as a PR comment, please \
+          provide the github-token in the action inputs."
 
           if [[ ! "$error_message" =~ "$expected_message" ]]; then
             echo "Expected error message to contain: $expected_message"

diff --git a/README.md b/README.md
@@ -20,9 +20,9 @@ reduce your container image size as early as possible.
 | Name&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | Type    | Required | Default                                                                                | Description&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |
 | ---------------------------------------------------------------------------------------------------------------------------------- | ------- | -------- | -------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | image               | String  | true  |                                                                                        | Image to analyze                                                                                                                                             |
-| always-comment      | Boolean | false | `false`                                                                                | Post dive analysis results as PR comment regardless of whether any inefficiencies were found. By default, comments are only posted when issues are detected. |
+| always-comment      | Boolean | false | `false`                                                                                | Post dive analysis results as PR comment regardless of whether any inefficiencies were found. By default, comments are only posted when issues are detected. Requires `github-token` |
 | config-file         | String  | false | `${{ github.workspace }}/.dive.yaml`                                                   | Path to [dive config file](https://github.com/joschi/dive#ci-integration)                                                                                    |
-| github-token        | String  | false |                                                                                        | GitHub token to post PR comment on dive failure                                                                                                              |
+| github-token        | String  | false |                                                                                        | GitHub token to post PR comment with dive analysis                                                                                                              |
 | dive-image-registry | String  | false | `ghcr.io/joschi/dive`                                                                  | Docker registry to pull the Dive image from                                                                                                                  |
 | dive-image-version  | String  | false | `0.13.1@sha256:f016a4bd2837` `130545e391acee7876aa5f7258` `ccdb12640ab4afaffa1c597d17` | Version of the Dive docker image to use. <br> While `latest` is supported, using a specific version with SHA is recommended for security and reproducibility |
 

diff --git a/action.yml b/action.yml
@@ -11,15 +11,15 @@ inputs:
   always-comment:
     description: Post dive analysis results as PR comment regardless of whether
       any inefficiencies were found. By default, comments are only posted when
-      issues are detected.
+      issues are detected. Requires `github-token`
     required: false
     default: 'false'
   config-file:
     description: Path to dive config file
     required: false
     default: ${{ github.workspace }}/.dive.yaml
   github-token:
-    description: GitHub Token to post PR comment
+    description: GitHub token to post PR comment with dive analysis
     required: false
   dive-image-registry:
     description: Docker registry to pull the Dive image from