Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate eol python versions 3.6 and 3.7, enable support for 3.11 #304

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Deprecate eol python versions 3.6 and 3.7, enable support for 3.11 #304

merged 14 commits into from
Aug 10, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Jul 26, 2023 •
edited
Loading

This pull request deprecates the TARDIS support of Python 3.6 and 3.7. As a consequence, TARDIS supports now also Python 3.11.

  • Adapt deployment tests
  • Adapt unittests
  • Adapt black target version and pre commit hooks
  • Adapt docker containers for deployment tests
    • Use rh-python38 on Centos 7
    • Deprecate Centos Stream 8 container (discontinued in HEP)
    • Use python3.9 on Rocky 8
  • Adapt cobald-tardis containers
    • Use Python 3.10 on cobald-tardis container
    • Use Rocky 8 and python3.9 on cobald-tardis-htcondor container
  • Deprecate backports.cached_property and replace it using functools

Closes #303

@giffels giffels changed the title Deprecated eol python versions 3.6 and 3.7 Deprecate eol python versions 3.6 and 3.7 Jul 26, 2023
@giffels giffels force-pushed the deprecated-eol-python-versions branch 4 times, most recently from 96b538e to b30beb2 Compare July 27, 2023 08:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (012da0f) 98.90% compared to head (11d00bb) 98.84%.

❗ Current head 11d00bb differs from pull request most recent head 1ba435c. Consider uploading reports for the commit 1ba435c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   98.90%   98.84%   -0.06%     
==========================================
  Files          55       56       +1     
  Lines        2277     2345      +68     
==========================================
+ Hits         2252     2318      +66     
- Misses         25       27       +2
Files Changed Coverage Δ
tardis/resources/drone.py 100.00% <100.00%> (ø)
tardis/utilities/asyncbulkcall.py 96.15% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giffels giffels added the enhancement New feature or request label Jul 28, 2023
@giffels giffels self-assigned this Jul 28, 2023
giffels
giffels commented Jul 31, 2023
View reviewed changes
tests/adapters_t/sites_t/test_fakesite.py
@@ -3,7 +3,7 @@
from tardis.interfaces.siteadapter import ResourceStatus
from tardis.utilities.attributedict import AttributeDict

from ...utilities.utilities import run_async
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this issue with unittest imports, which is not related to the deprecation of Python 3.6 and 3.7

@giffels giffels changed the title Deprecate eol python versions 3.6 and 3.7 Deprecate eol python versions 3.6 and 3.7, enable support for 3.11 Jul 31, 2023
@giffels giffels marked this pull request as ready for review July 31, 2023 14:07
@giffels giffels requested review from a team, maxfischer2781 and RHofsaess and removed request for a team July 31, 2023 14:07
maxfischer2781
maxfischer2781 previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Welcome to the Century of the Fruitbat! 🦇

This was referenced Aug 7, 2023
Merged
Merged
@giffels giffels force-pushed the deprecated-eol-python-versions branch from 11d00bb to 7d74faf Compare August 8, 2023 10:48
@giffels giffels requested a review from maxfischer2781 August 8, 2023 11:11
maxfischer2781
maxfischer2781 previously approved these changes Aug 9, 2023
View reviewed changes
@giffels giffels requested review from eileen-kuehn and removed request for eileen-kuehn August 9, 2023 17:07
@giffels giffels force-pushed the deprecated-eol-python-versions branch from 7d74faf to 1ba435c Compare August 10, 2023 11:39
@giffels giffels requested a review from maxfischer2781 August 10, 2023 11:39
RHofsaess
RHofsaess approved these changes Aug 10, 2023
View reviewed changes
Copy link

@RHofsaess RHofsaess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

maxfischer2781
maxfischer2781 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are fine with the test failures please go ahead.

@giffels giffels added this pull request to the merge queue Aug 10, 2023
@giffels
Copy link
Member Author

giffels commented Aug 10, 2023

Thanks! Bye, bye python3.{6,7}, welcome python3.11.

Merged via the queue into MatterMiners:master with commit aa30b0c Aug 10, 2023
@giffels giffels deleted the deprecated-eol-python-versions branch August 10, 2023 14:24
@giffels
Copy link
Member Author

giffels commented Aug 10, 2023

Thanks! Bye, bye python3.{6,7}, welcome python3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxfischer2781 maxfischer2781 maxfischer2781 approved these changes

@RHofsaess RHofsaess RHofsaess approved these changes

Assignees

@giffels giffels

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Minimal Python version 3.8
4 participants
@giffels @codecov-commenter @maxfischer2781 @RHofsaess