Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev - Create New Remote #6

Open
MattS8 opened this issue Jun 4, 2019 · 0 comments
Open

dev - Create New Remote #6

MattS8 opened this issue Jun 4, 2019 · 0 comments
Assignees
@MattS8
Labels
android Related to android application. under-development UX Related to user experience (i.e. graphics, animations, unresponsiveness, etc)

Comments

@MattS8
Copy link
Owner

MattS8 commented Jun 4, 2019

No description provided.

@MattS8 MattS8 added android Related to android application. UX Related to user experience (i.e. graphics, animations, unresponsiveness, etc) labels Jun 4, 2019
@MattS8 MattS8 self-assigned this Jun 4, 2019
MattS8 added a commit that referenced this issue Jul 4, 2019
@MattS8
Android - Working on #6
3622b17 
- Added step features to SuperBottomSheet Cards instead of separate activities
- Minor fixes
- Minor change to validator util
@MattS8 MattS8 closed this as completed Jul 9, 2019
@MattS8 MattS8 reopened this Aug 10, 2019
@MattS8 MattS8 changed the title Develop UI for Creating New Remote Profile dev - Create New Remote Aug 10, 2019
MattS8 added a commit that referenced this issue Aug 10, 2019
@MattS8
Android - #6, #15, #19
31c1de1 
#6:
- Added "Create From" view for initial step in creating a new remote

#15:
- Using default Google BottomSheet (instead of SuperBottomSheet)
- Removed remoteTemplateSheet (used SuperBottomSheet)

#19:
- Added "fromSnapshot" function to convert snapshot document to RemoteProfileTemplate

Misc:
- Changed tempRemoteProfile to val (might want to change back to mutable)
- Added "copyFrom" function to make a surface-level copy of a remote from the DB to tempData
MattS8 added a commit that referenced this issue Aug 24, 2019
@MattS8
Android - #22, #6
940bc2d 
- Moved remote creation into a new 'RemoteCreator' class
MattS8 added a commit that referenced this issue Sep 19, 2019
@MattS8
Android - #16, #6, Misc
d6f46c2 
#16
- Changed ButtonStyle to an enum class instead of int
- Begun implementing ButtonCreator Class
    - Note: this creator can hold onto a reference to an Activity in order to call startActivityForResult

#6
- Renamed BottomDialogState to RemoteDialogState
- added checks for transition vs actual dismissal when setting state
- properly sets state  whenever a new dialog is shown (whoops)
MattS8 added a commit that referenced this issue Sep 19, 2019
@MattS8
Android - #16, #6
4c832f0 
#16
- Changed ButtonStyle to an enum class instead of int
- Begun implementing ButtonCreator Class
    - Note: this creator can hold onto a reference to an Activity in order to call startActivityForResult

#6
- Renamed BottomDialogState to RemoteDialogState
- added checks for transition vs actual dismissal when setting state
- properly sets state  whenever a new dialog is shown (whoops)
MattS8 added a commit that referenced this issue Oct 5, 2019
@MattS8
Android - #16, #23, #6, #18, Misc
2ba1913 
#16
- Added constructor parameter to buttons, requiring a style upon creation
- Made global TempButton observable
- Implemented majority of ButtonCreator class
- Button class now creates the proper number of property/command variables based on style set

#23
- Added CommandCreationView (NYI)
- Added CommandCreator class
- Added CommandFromRemoteActivity for selecting a command based on existing remote button (NYI)

#6
- reverts state and calls onCreateDialogDismiss() from dialog's onDismiss listener

#18
- Added a checkUserData function that checks if all steps needed to move off of splash screen were completed while app was in background


Misc
- Updated Utils (request codes, extensions, etc)
- Commented out old classes (CB_*, CommandsAdapter)
- LOTS of res/layout changes
MattS8 added a commit that referenced this issue Nov 22, 2019
@MattS8
Android - #6, #17, #23, #22
9c7f2d4 
#6
- RemoteCreator reworked to more closely resemble the structure of other 'creator' modules
- Now contains a context reference
- Keeps track of it's visibility in its own state now

#17
RemoteLayout
- Setting the binding reference now properly updates the internal button creator and sets up the adapters
- Now contains the 'topPadding' value to set for the remote layout
- Lots of the logic regarding updating the layout have been moved to this class (i.e. 'edit mode' listener, 'add button' listener, 'button creation process complete' listener)

#23
CommandCreator
- Now 'resets' many of the internal variables to their default state when the dialog is dismissed. Since dismissing the dialog is only done when a user completely backs out or finishes a process now, this is a viable solution to resetting the creator for further use.
- Fixed a bug where instructionsBinding and newCommandSheetBinding weren't set to null upon removing the context reference
- Fixed a bug where 'showActionsFromDialog()' wasn't using the new 'createDialog()' function

#22
- The button creator was removed and is now found within the RemoteLayout variable
- The state variables 'isShowingCreateRemoteView' and 'isShowingCreateButtonView' have been removed as they are now unnecessary
-  Removed several listeneners which are now found within the RemoteLayout class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattS8 MattS8

Labels
android Related to android application. under-development UX Related to user experience (i.e. graphics, animations, unresponsiveness, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MattS8