Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaults general fixes and QOL #340

Closed
5 tasks done
tegefaulkes opened this issue Feb 15, 2022 · 3 comments · Fixed by #266
Closed
5 tasks done

Vaults general fixes and QOL #340

tegefaulkes opened this issue Feb 15, 2022 · 3 comments · Fixed by #266
Assignees
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Feb 15, 2022

Specification

This issue relates to general fixes and QOL changes.
Change to selective imports in all relevant domains. And ensure there are no import cycles in the vaults domain.

     ┌──────────────────┐
     │                  │
     │                  │
Errors────►Types ──┐    │
  │         │      │    │
  │         │      │    │
  ▼         │      │    │
Utils ◄─────┘      │    │
  │                ▼    │
  └─────────► Classes ◄─┘

Additional context

Tasks

  1. switch Vaults domain to using selective imports.
  2. switch vaults tests to using selective imports.
  3. Vaults domain errors need to be reviewed and updated with proper descriptions and sysexit codes.
  4. VaultId decoding needs to be checked for if fromMultibase throws an error. this needs to be fixed.
  5. VaultsLog GRPC method can use the google timestamp type for the timestamp.
@tegefaulkes tegefaulkes added the development Standard development label Feb 15, 2022
@tegefaulkes tegefaulkes changed the title Switching to selective imports in vaults domain Vaults general fixes and QOL Feb 16, 2022
@CMCDragonkai
Copy link
Member

It would be similar to:

  protected connections: Map<NodeIdString, ConnectionAndLock> = new Map();

So yea vault map (the in-memory one) would use VaultIdString.

tegefaulkes added a commit that referenced this issue Feb 21, 2022
@tegefaulkes
Copy link
Contributor Author

decodeVaultId still throws errors in some circumstances. I've made a comment on the PR related to this at MatrixAI/js-id#14 (comment).

@tegefaulkes
Copy link
Contributor Author

VaultId decoding needs to be checked for if fromMultibase throws an error. this needs to be fixed. will be fixed after MatrixAI/js-id#15 is merged and the js-id version is updated here.

tegefaulkes added a commit that referenced this issue Feb 22, 2022
tegefaulkes added a commit that referenced this issue Feb 28, 2022
- selective imports
- error descriptions updated
- Using google `Timestamp` message in `LogEntry` message
tegefaulkes added a commit that referenced this issue Mar 9, 2022
tegefaulkes added a commit that referenced this issue Mar 9, 2022
tegefaulkes added a commit that referenced this issue Mar 9, 2022
tegefaulkes added a commit that referenced this issue Mar 9, 2022
tegefaulkes added a commit that referenced this issue Mar 9, 2022
- selective imports
- error descriptions updated
- Using google `Timestamp` message in `LogEntry` message
- fixing comments
@teebirdy teebirdy added the r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management
3 participants