Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added export option to secrets env #342 #348

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Sooryasanand
Copy link

@Sooryasanand Sooryasanand commented Dec 18, 2024

Description

I have introduced an export flag in options.ts to determine whether the export keyword should be prefixed to environment variables for shell usage. This is relevant for Unix-based systems, where export is required to make the variables available to child processes. On Windows, however, the export keyword or an equivalent is unnecessary because a child process automatically inherits the environment variables of its parent process. This behavior is documented on the official Microsoft website: Environment Variables.

Issues Fixed

Tasks

  • 1. Add export option for json
  • 2. Add Tests

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

tests/secrets/env.test.ts Outdated Show resolved Hide resolved
src/utils/options.ts Outdated Show resolved Hide resolved
tests/secrets/env.test.ts Outdated Show resolved Hide resolved
tests/secrets/env.test.ts Outdated Show resolved Hide resolved
tests/secrets/env.test.ts Outdated Show resolved Hide resolved
@CMCDragonkai
Copy link
Member

If review comments are fixed, resolve the threads with a comment, don't leave it open.

chore: added test for env export
@aryanjassal
Copy link
Member

I have gone through the PR and made any required changes. Linting gives the all-clear, and the tests are also all passing. This should now be ready for merging.

@CMCDragonkai
Copy link
Member

Can someone add a comment to #342 explaining what this PR brings in from a UI/UX perspective.

@CMCDragonkai
Copy link
Member

Also not all conversations here have been resolved.

@CMCDragonkai
Copy link
Member

@aryanjassal #342 or @Sooryasanand please summarise the feature in #342.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add export formats to secrets env command
4 participants