-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added export option to secrets env #342 #348
base: staging
Are you sure you want to change the base?
Conversation
If review comments are fixed, resolve the threads with a comment, don't leave it open. |
chore: added test for env export
43fc187
to
5a1bc67
Compare
I have gone through the PR and made any required changes. Linting gives the all-clear, and the tests are also all passing. This should now be ready for merging. |
Can someone add a comment to #342 explaining what this PR brings in from a UI/UX perspective. |
Also not all conversations here have been resolved. |
@aryanjassal #342 or @Sooryasanand please summarise the feature in #342. |
Description
I have introduced an export flag in options.ts to determine whether the export keyword should be prefixed to environment variables for shell usage. This is relevant for Unix-based systems, where export is required to make the variables available to child processes. On Windows, however, the export keyword or an equivalent is unnecessary because a child process automatically inherits the environment variables of its parent process. This behavior is documented on the official Microsoft website: Environment Variables.
Issues Fixed
secrets env
command #342Tasks
Final checklist