Pick up timely fix #360 #5794
Merged
Pick up timely fix #360 #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-stoev
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
@frankmcsherry #5622 is indeed fixed but unfortunately this does not fix #5774 . Even with commit 576e0ae , the test case for this bug produces this with 64 workers:
pstoev@Ubuntu-2004-focal-64-minimal:~/randgen$ cat 5774.sql | psql -p 6875 -h 127.0.0.1 -U materialize | sort | uniq -c
...
176 31
1 62 <- 1 wrong result
I guess this can be merged now and #5774 be left open?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a timely fix that was the source of the problems in MaterializeInc/database-issues#1731 and MaterializeInc/database-issues#1780 (edit: this later issue is unfixed), as well as looming problems observed in TimelyDataflow/differential-dataflow#304.
This fixes the issue for me locally (and it makes sense in each case that it would cause the issue) but I haven't done further testing to see if the issue lingers. Ideally this is a strict improvement.
Fixes MaterializeInc/database-issues#1731
This change is