test: refactor load tests / demos to use a common mz-client #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touches #3709
Also get rid of macros for view definition. Touches #3709
benesch
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
This is fantastic! Thanks so much for doing this!
Reviewed 3 of 3 files at r1, 9 of 9 files at r2, 20 of 20 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 12, 2022
This commit makes the storage usage collection interval configurable, so that it is easier to test. Works towards resolving MaterializeInc#3739
3 tasks
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 12, 2022
This commit makes the storage usage collection interval configurable, so that it is easier to test. Works towards resolving MaterializeInc#3739
jkosh44
added a commit
that referenced
this pull request
Sep 13, 2022
This commit makes the storage usage collection interval configurable, so that it is easier to test. Works towards resolving #3739
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 14, 2022
Previously, the Coordinator would collect storage metrics on a regular interval using a tokio::time::interval. This was lacking in the following ways: - Any time spent waiting would be forgotten in between restarts. - A crash loop could potentially cause repeated consecutive collections if we decided to blindly collect usages on restart. This commit changes the logic to check when the previous collection was and see how much more time needs to be spent waiting. Fixes MaterializeInc#3739
3 tasks
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 14, 2022
Previously, the Coordinator would collect storage metrics on a regular interval using a tokio::time::interval. This was lacking in the following ways: - Any time spent waiting would be forgotten in between restarts. - A crash loop could potentially cause repeated consecutive collections if we decided to blindly collect usages on restart. This commit changes the logic to check when the previous collection was and see how much more time needs to be spent waiting. Fixes MaterializeInc#3739
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 19, 2022
Previously, the Coordinator would collect storage metrics on a regular interval using a tokio::time::interval. This was lacking in the following ways: - Any time spent waiting would be forgotten in between restarts. - A crash loop could potentially cause repeated consecutive collections if we decided to blindly collect usages on restart. This commit changes the logic to check when the previous collection was and see how much more time needs to be spent waiting. Fixes MaterializeInc#3739
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 19, 2022
Previously, the Coordinator would collect storage metrics on a regular interval using a tokio::time::interval. This was lacking in the following ways: - Any time spent waiting would be forgotten in between restarts. - A crash loop could potentially cause repeated consecutive collections if we decided to blindly collect usages on restart. This commit changes the logic to check when the previous collection was and see how much more time needs to be spent waiting. Fixes MaterializeInc#3739
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Sep 19, 2022
Previously, the Coordinator would collect storage metrics on a regular interval using a tokio::time::interval. This was lacking in the following ways: - Any time spent waiting would be forgotten in between restarts. - A crash loop could potentially cause repeated consecutive collections if we decided to blindly collect usages on restart. This commit changes the logic to check when the previous collection was and see how much more time needs to be spent waiting. Fixes MaterializeInc#3739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MaterializeInc/database-issues#1160
This change is