Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade twine #28374

Merged
merged 1 commit into from
Jul 20, 2024
Merged

ci: upgrade twine #28374

merged 1 commit into from
Jul 20, 2024

Conversation

sjwiesman
Copy link
Contributor

Twine is the library used to deploy dbt-materialize to PyPi. Recent versions are broken with missing metadata keys. The issue has been resolved in the latest release.

Example failure: https://buildkite.com/materialize/deploy/builds/15079#0190cc52-c16a-4ea4-8020-e1df5daed947
Twine issue: pypa/twine#977

Motivation

Tips for reviewer

Checklist

Twine is the library used to deploy dbt-materialize to PyPi. Recent
versions are broken with missing metadata keys. The issue has been
resolved in the latest release.

Example failure: https://buildkite.com/materialize/deploy/builds/15079#0190cc52-c16a-4ea4-8020-e1df5daed947
Twine issue: pypa/twine#977
@sjwiesman sjwiesman requested a review from a team as a code owner July 19, 2024 20:19
@chuck-alt-delete
Copy link
Contributor

Do you need to also update the twine version in ./misc/python/requirements.txt?

@sjwiesman
Copy link
Contributor Author

It's already upgraded there

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints from QA side

@sjwiesman sjwiesman merged commit 19a21cd into MaterializeInc:main Jul 20, 2024
85 checks passed
@sjwiesman sjwiesman deleted the upgrade-twine branch July 20, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants