Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gulp to 4.0.0 #2

Closed
wants to merge 1 commit into from
Closed

upgrade gulp to 4.0.0 #2

wants to merge 1 commit into from

Conversation

alex-gon
Copy link

@alex-gon alex-gon commented Jun 3, 2019

The changes in this branch are to upgrade gulp to version 4.0.0.

We decided to upgrade gulp because gulp tasks would fail if you were running node v10+.
This issue is explained here: https://github.com/mozilla/pdf.js/issues/10355

@alex-gon alex-gon requested a review from shaymdev June 3, 2019 15:10
@shaymdev
Copy link

shaymdev commented Jun 3, 2019

Was this change made manually or did you merge in a commit that had been made on mozilla/pdfjs/master? They made the upgrade to gulp 4 on their master branch and it's in the latest beta release (which has been in beta for 4 months). I'm wondering if, rather than make similar changes on our branch that could make future merges from master more difficult, we should get this gulp upgrade from master. I can guarantee that their changes on their branch is much more thoroughly tested than ours (not to mention made by more experienced maintainers of this library). We could take their changes now by putting ourselves on the beta release rather than the stable. Or we could live with the workaround of needing an older version of node to build the library until their changes make it to a stable release.

Thoughts @alex-gon?

@alex-gon
Copy link
Author

alex-gon commented Jun 3, 2019

I made these changes manually based on this merge to mozilla master: mozilla#10266
I decided to do it manually because we have a few of our own gulp tasks that also need to be updated.
I am okay with either of your other options.

@shaymdev
Copy link

shaymdev commented Jun 3, 2019

I say let's hold off on the change, I'll find a way to document our situation where newer node won't jive well with the build until we're up to a version that has the gulp 4 upgrade.

@shaymdev shaymdev closed this Jun 3, 2019
@shaymerrill-mc shaymerrill-mc deleted the upgrade-gulp branch January 10, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants