Add vlan validation in config interface ip add command #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~ Signed-off-by: mati <mati@marvell.com>
amazor
reviewed
Feb 6, 2024
shiraez
reviewed
Feb 6, 2024
Signed-off-by: mati <mati@marvell.com>
amazor
approved these changes
Feb 6, 2024
Test that vlan exists Added an optional param (option) --ignore-vlan which will test only format ~ Signed-off-by: matiAlfaro <mati@marvell.com>
Signed-off-by: matiAlfaro <mati@marvell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~
What I did
Fix for -16975
Prevent configuration of illegal Vlan name in "config interface ip add" command
How I did it
Added Vlan name validation
How to verify it
Positive tests
config interface ip add Vlan100 1.1.1.1/24
config interface ip add Vlan4093 1.1.1.1/24
Negative tests
config interface ip add Vlan000000000000003 1.1.1.1/24
config interface ip add Vlan01 1.1.1.1/24
config interface ip add Vlan1.2 1.1.1.1/24
Previous command output (if the output of a command-line utility has changed)
On illegal Vlan name command succeeded with no error
New command output (if the output of a command-line utility has changed)
config interface ip add Vlan030 1.1.1.1/24
Error: Vlan030 is not a valid Vlan name