support multiple license files #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinP7r
approved these changes
Dec 11, 2023
| let new = Acknowledgement(title: pkgDir, license: String(data: data, encoding: .utf8)!) | ||
| acknowledgements.append(new) | ||
| for file in licenseFiles { | ||
| guard let data = fman.contents(atPath: "\(packageCachePath)/\(pkgDir)/\(file)") else { continue } |
There was a problem hiding this comment.
[nit]
It doesn't matter for two elements, but usually I would prefer if let with an early break to prevent unnecessary loop iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all repo's have the specific
LICENSEfile that AckGen is searching for. Sometimes, license files are namedLICENSE.txtThis adds a slight refactor to loop through a list of license files (
LICENSE,LICENSE.txt) in the CLI. Future this could be added as an input parameter.An example of a license with the txt extension is https://github.com/apple/swift-algorithms