Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions Workflows CI_CD #32 #38

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

PratikKumar125
Copy link
Contributor

Whenever a new PR will be created or updated the workflow will run "cargo clippy" and "cargo test".
And depending upon it's results, after a successful merging to master branch, it will run the "cargo build" and will save the artifacts.

- name: Upload artifact
uses: actions/upload-artifact@v2
with:
name: program-zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the program right now is called grout-wm, maybe the zip-file should be called grout-wm.zip? Also, would it be possible to get the version number from Cargo.toml? So the file would be grout-wm-version.zip?


jobs:
test:
runs-on: ubuntu-latest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux? Since its a program for Microsoft Windows, does a build on linux produce a windows exe?

@PratikKumar125
Copy link
Contributor Author

Did some necessary changes. Can you review it now if it's fine now.

@MartinAskestad
Copy link
Owner

@PratikKumar125 Thank you.

@MartinAskestad MartinAskestad merged commit b6f5eba into MartinAskestad:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants