-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Location header to run creation #701
Added Location header to run creation #701
Conversation
a646f57
to
b1d3352
Compare
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
===========================================
+ Coverage 65.78% 65.89% +0.1%
Complexity 339 339
===========================================
Files 109 109
Lines 1888 1894 +6
Branches 136 136
===========================================
+ Hits 1242 1248 +6
Misses 401 401
Partials 245 245
Continue to review full report at Codecov.
|
First time using JAX-RS, so not sure if this is the best way to get the location header. Didn't want to hardcode the value but the reflection step to get the method seems like it might be bad. |
@@ -33,6 +33,10 @@ | |||
@NonNull Run.State state; | |||
@Nullable Map<String, String> args; | |||
|
|||
public UUID getId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Lombok will generate getters/setters for us. So, we don't need to explicitly define one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkijak For your first time using JAX-RS, this PRs solid. Great work! 💯 Sure, there may be alternative ways to add the Location
header, but I'm ok with merging this for now.
Note: Left a minor comment on using lombok to generate mutators for Run
. I'll merge once addressed.
@wslulciuc made the update but the commits are messy. Should I close this and open another? |
c9a2281
to
7f1745b
Compare
Fix for MarquezProject#699 Signed-off-by: Nicolas Kijak <nick.kijak@pngaming.com>
7f1745b
to
7884ffb
Compare
@wslulciuc squashed |
Fix for #699