-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null pointer error on job event for static lineage #2974
Conversation
Signed-off-by: sharpd <davidsharp7@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2974 +/- ##
============================================
- Coverage 81.19% 81.18% -0.02%
Complexity 1506 1506
============================================
Files 268 268
Lines 7360 7356 -4
Branches 325 325
============================================
- Hits 5976 5972 -4
Misses 1226 1226
Partials 158 158 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @davidsharp7 💯 💯 👍
Signed-off-by: sharpd <davidsharp7@gmail.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
Signed-off-by: sharpd <davidsharp7@gmail.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
Problem
Emitting a JobEvent with input and/or output datasets causes a HTTP500 error in the API, which results from a nullPointerException in Marquez.
Closes: #2925
Solution
Make runuuid/Lineage event type nullable
on
insertInputDatasetFacetsFor
insertOutputDatasetFacetsFor
Nullable
Following post which used to fail now posts correctly.
One-line summary:
Make runuuid/Lineage event type nullable
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)