Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arg --db-port to docker/up.sh #2961

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

wslulciuc
Copy link
Member

This PR add arg --db-port to docker/up.sh:

% ./docker/up.sh --help
usage: ./up.sh [FLAGS] [ARG...]
A script used to run Marquez via Docker

EXAMPLES:
  # Build image from source
  $ ./up.sh --build

  # Build image from source, then seed HTTP API server with metadata
  $ ./up.sh --build --seed

  # Use tagged image
  ./up.sh --tag X.Y.X

  # Use tagged image, then seed HTTP API server with metadata
  ./up.sh --tag X.Y.X --seed

  # Set HTTP API server port
  ./up.sh --api-port 9000

ARGUMENTS:
  -a, --api-port int          api port (default: 5000)
  -m, --api-admin-port int    api admin port (default: 5001)
  -w, --web-port int          web port (default: 3000)
  -d, --db-port int           database port (default: 5432)
  -e --search-port int        search port (default: 9200)
  -t, --tag string            docker image tag (default: 0.50.0)
  --args string               docker arguments

FLAGS:
  -b, --build           build images from source
  -s, --seed            seed HTTP API server with metadata
  -d, --detach          run in the background
  --no-web              don't start the web UI
  --no-search           don't start search
  --no-volumes          don't create volumes
  -h, --help            show help for script

Usage

Use arg --db-port to set the postgres port to 2345:

% ./docker/up.sh --api-port 9000 --db-port 2345 --seed --build

Below, you can see the postgres port is listening on 2345 instead 5432 (the default):

CONTAINER ID   IMAGE                                PORTS
b782a221d067   marquezproject/marquez-web:0.50.0    0.0.0.0:3000->3000/tcp
c810172bf769   marquezproject/marquez:0.50.0        0.0.0.0:5001->5001/tcp, 5000/tcp, 0.0.0.0:9000->9000/tcp
b491eed4786e   postgres:14                          0.0.0.0:2345->2345/tcp, 5432/tcp
3f8a549608e2   ankane/pghero                        0.0.0.0:8080->8080/tcp
c13c047c94e2   opensearchproject/opensearch:2.5.0   0.0.0.0:9200->9200/tcp, 9600/tcp, 0.0.0.0:9300->9300/tcp, 9650/tcp

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
@boring-cyborg boring-cyborg bot added the docker label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 5d38425
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/67231a977058310008122609

@wslulciuc wslulciuc enabled auto-merge (squash) October 31, 2024 05:52
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (3f4e507) to head (5d38425).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2961   +/-   ##
=========================================
  Coverage     81.19%   81.19%           
  Complexity     1505     1505           
=========================================
  Files           268      268           
  Lines          7358     7358           
  Branches        325      325           
=========================================
  Hits           5974     5974           
  Misses         1226     1226           
  Partials        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit ce147a2 into main Oct 31, 2024
16 checks passed
@wslulciuc wslulciuc deleted the override-db-port-in-docker-up.sh branch October 31, 2024 06:11
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 4, 2025
* Remove search from gitpod cmd

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

* Add arg `--db-port` to `docker/up.sh`

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

---------

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* Remove search from gitpod cmd

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

* Add arg `--db-port` to `docker/up.sh`

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

---------

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* Remove search from gitpod cmd

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

* Add arg `--db-port` to `docker/up.sh`

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>

---------

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants