Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Lineage Metrics #2900

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Current Lineage Metrics #2900

merged 7 commits into from
Oct 8, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Sep 24, 2024

Problem

We currently in our materialized view lineage tables don't provide the current hour and day respectively, which is the timeframe that our materialized view did not get

Solution

  • Separate tables for current_hour_lineage_metrics and current_day_lineage_metrics
  • Deletes all table data at hourly and daily intervals as part of the cleanup. (Only retains current hour and current day)
  • Inserts to simple table on OL events.

One-line summary: Includes current events in the lineage metrics aggregations.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 6ae44db
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/670587b82060760007e29ea5

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.92%. Comparing base (9450410) to head (6ae44db).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
api/src/main/java/marquez/api/StatsResource.java 0.00% 5 Missing ⚠️
...pi/src/main/java/marquez/service/StatsService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2900      +/-   ##
============================================
- Coverage     82.97%   82.92%   -0.05%     
  Complexity     1485     1485              
============================================
  Files           264      264              
  Lines          6849     6853       +4     
  Branches        315      316       +1     
============================================
  Hits           5683     5683              
- Misses         1011     1015       +4     
  Partials        155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
phixMe added 3 commits October 7, 2024 14:24
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 🥇

@wslulciuc wslulciuc merged commit d180f24 into main Oct 8, 2024
15 of 16 checks passed
@wslulciuc wslulciuc deleted the feature/current-lineage-metrics branch October 8, 2024 21:09
@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 11, 2024
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* Current day and hour lineage metrics + cleanup.

* Fixing db write field names.

* Newline

* Adding timezone.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Updating for code review comments.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Independent table to lineage events table.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Fixing removed refs.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

---------

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants