Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and fix changelog script in dev #2816

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

merobi-hub
Copy link
Collaborator

Problem

The changelog is not current. Also, the script for adding draft changes to the changelog is broken due to incorrect dependency versions.

Solution

Updates the changelog and fixes the script requirements in dev.

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • [ x] You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • [x ] Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the docs label May 17, 2024
@merobi-hub merobi-hub requested a review from wslulciuc May 17, 2024 15:31
Copy link

netlify bot commented May 17, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit c002bd8
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/664780012c86c200088b574f

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (226d275) to head (100a0b8).

Current head 100a0b8 differs from pull request most recent head c002bd8

Please upload reports for the commit c002bd8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2816   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity     1441     1441           
=========================================
  Files           251      251           
  Lines          6503     6503           
  Branches        302      302           
=========================================
  Hits           5500     5500           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@merobi-hub merobi-hub force-pushed the 0.47.0/changelog branch 2 times, most recently from 26a5d5f to 100a0b8 Compare May 17, 2024 15:44
@merobi-hub merobi-hub marked this pull request as draft May 17, 2024 15:58
Signed-off-by: merobi-hub <merobi@gmail.com>
@merobi-hub merobi-hub marked this pull request as ready for review May 17, 2024 16:04
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wslulciuc wslulciuc enabled auto-merge (squash) May 17, 2024 16:09
@wslulciuc wslulciuc merged commit f2d3c22 into main May 17, 2024
15 checks passed
@wslulciuc wslulciuc deleted the 0.47.0/changelog branch May 17, 2024 16:13
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
Signed-off-by: merobi-hub <merobi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants