Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various small fixes/tweaks - draft #27264

Closed
wants to merge 135 commits into from
Closed

Various small fixes/tweaks - draft #27264

wants to merge 135 commits into from

Conversation

classicrocker883
Copy link
Contributor

this is for drafting another PR

classicrocker883 and others added 30 commits December 6, 2023 09:50
@classicrocker883
general small fixes/tweaks
41d31ca 
remove whitespace, add hyphen (-)
remove unused `INLINE_USART_IRQ`
optimize code
@classicrocker883
Update Probe Offset dependencies
f93e12a 
have `HAS_Z_OFFSET_ITEM` defined in one file
undef PROBE_OFFSET_ZMIN when ProUI is disabled
@classicrocker883
edit Conditionals_post.h
c10d5dc
@thisiskeithb
Fix Cutter.md, more gcode => G-code
87dbb8e
@classicrocker883
omit PROBE_OFFSET_ZMIN/MAX
806a728
@classicrocker883
change to HAS_LEVELING - creality dwin.cpp
f2368ee
@classicrocker883
replace HAS_ONESTEP_LEVELING => HAS_AUTOLEVEL
82c2457 
"#if DISABLED(PROBE_MANUALLY) && ANY(AUTO_BED_LEVELING_BILINEAR, AUTO_BED_LEVELING_LINEAR, AUTO_BED_LEVELING_3POINT, AUTO_BED_LEVELING_UBL)" is literally HAS_AUTOLEVEL
@thinkyhead
Update Conditionals_post.h
d2b3bbb
@thinkyhead
serial tweaks
979edb6
@classicrocker883
Conditionals_post.h replace HAS_ZOFFSET_ITEM => PROBE_SELECTED
ee55dfe
@classicrocker883
Update Conditionals_post.h, include default-no probe/no mesh
e696be3 
if one had no Probe and no Mesh, they can still adjust their Z-Offset
@classicrocker883
add default-no probe, no mesh to tests
4ef2cbf
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
55f5122 
… into bugfix-2.1.x-Dec
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
27b2353 
… into bugfix-2.1.x-Dec
@classicrocker883
simplify MPC/PID Plot, dwin.cpp
aa7e068
@classicrocker883
add HAS_TRAMMING_WIZARD
8a6bcc2 
swap to TERN_ in switch case
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
2276bf6 
… into bugfix-2.1.x-Dec
@classicrocker883
update dwin.cpp spacing
0a6d2b2
@classicrocker883
update DWIN UI - spacing
cff0e4f 
removed COLOR_AQUA - unused, same as COLOR_CYAN
@classicrocker883
update ProUI, remove unused, use Move/Probe methods
cef2bda
@classicrocker883
revert #undef, change to _OFFSET_ZMIN|MAX
a77fec9 
fix JyersUI - MAX|MIN_Z_OFFSET
@classicrocker883
tweak spacing
590d66f
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
981aa04 
… into bugfix-2.1.x-Dec
@classicrocker883
small change
90607e1 
change from OPTCODE to #if
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
41b5f74 
… into bugfix-2.1.x-Dec
@classicrocker883
fix error, duplicate case
1c75a65
@classicrocker883
rename to G-Code, Marlin webui
843fc13
@classicrocker883
update digitpot spacing
7fabcef
@classicrocker883
update more spacing
5722f55
@classicrocker883
add ZeroMesh in editmesh menu
2184b96 
ResetMesh if HAS_MESH
classicrocker883 and others added 26 commits February 21, 2024 23:01
@classicrocker883
update ubl_g29.cpp comment spacing
5f93b1c
@classicrocker883
captialize letter
51b786f
@classicrocker883
update comments+spacing, ubl files
a2d7fe9
@classicrocker883
update ubl_G29
0a006e0
@classicrocker883
update ubl_G29
37f3c36
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
71ba854 
… into bugfix-2.1.x-Dec
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
c1f7c2e 
… into bugfix-2.1.x-Dec
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
4aee98b 
… into bugfix-2.1.x-Dec
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
4a3a301 
… into bugfix-2.1.x-Dec
@classicrocker883
remove HAS_STATUS_MESSAGE w/HAS_DISPLAY, update DWIN, use ALL(...)
66cc566
@classicrocker883
add kill_screen to CrealityUI, group MarlinUI functions in JyersUI
9011371
@classicrocker883
add dwinPopupConfirm/Continue, update Creality/JyersUI dwinDrawString
e1b965b
@classicrocker883
#include in dwin.cpp
4411490
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
a09df0e 
… into bugfix-2.1.x-Dec
@classicrocker883
remove characters causing issue with make format-pins
2774a48
@classicrocker883
revert pin *.h
095230a
@classicrocker883
Update jyersui dwin.cpp - manualValueUpdate
0c1aee9
@classicrocker883
Update proui bedlevel_tools.cpp - manualValueUpdate
f6b4f75
@classicrocker883
update proui spacing/comments
349235a
@classicrocker883
Update jyers ui dwin.cpp
84567d8
@classicrocker883
Update dwin_popup.h spacing
098a62e
@thinkyhead
Merge branch 'bugfix-2.1.x' into pr/26502
72e4984
@classicrocker883
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
c10de0c 
… into bugfix-2.1.x-Dec
@classicrocker883
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-Dec
2354957
@classicrocker883
update GET_TEXT, marlinui.h
ce4bcfe
@classicrocker883
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-Dec
b61025f
@thinkyhead
Copy link
Member

this is for drafting another PR

Please don't use our PR queue to work on your PRs. Keep groups of changes like this in your own fork and parcel them out in smaller pieces to individual branches before submitting them as little PRs.

@thinkyhead thinkyhead closed this Jul 15, 2024
@classicrocker883
Copy link
Contributor Author

classicrocker883 commented Jul 16, 2024 •
edited
Loading

Keep groups of changes like this in your own fork and parcel them out in smaller pieces to individual branches before submitting them as little PRs.

that was I was doing, trying to separate this one. I like the Actions feature that automatically check tests when there is a Push.

how do I make this sort of check/test on my own?

@thisiskeithb
Copy link
Member

thisiskeithb commented Jul 16, 2024 •
edited
Loading

how do I make this sort of check/test on my own?

Enable Actions in your fork and:

  • Disable all of the referenced branches under On -> pull_request / push or add your branch name to the list so the workflow runs.
  • Disable the if: github.repository == 'MarlinFirmware/Marlin' line to allow the workflow to run or change it to your fork.

See https://docs.github.com/en/actions for more information on how to use GitHub Actions.

Another option (and least disruptive to your branch/fork) is to change to the Marlin project root and run make tests-all-local to run tests locally on your machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@classicrocker883 @thinkyhead @thisiskeithb