-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elegoo Neptune boards #24895
base: bugfix-2.1.x
Are you sure you want to change the base?
Elegoo Neptune boards #24895
Conversation
edbe62c
to
4e53e8f
Compare
9c6406f
to
bd422d3
Compare
Good evening @ivankravets ! Apparently the dev version of PlatformIO 6.1.6a3 is causing our CI to fail, so I added a commit here that skips the update-to-latest step. What do you recommend? |
a062534
to
7cdfdd9
Compare
@thinkyhead , thanks for pinging me! Could you point me to the CI build where I can learn more about the issue with the latest PIO-dev? I checked the latest failed Marlin builds and didn't find any issues related to the PlatformIO. |
For one CI test, LPC1768, the result looks like this...
Without So, I will add more diagnostic lines to the scripts on this PR and see what's going on here in CI that isn't happening locally. |
306d4cc
to
bf9a0b3
Compare
@ivankravets — I have a feeling this is what is breaking, causing our def is_pio_build():
from SCons.Script import DefaultEnvironment
env = DefaultEnvironment()
return not env.IsIntegrationDump() Does that seem possible? Could some change in PIO only affecting the way it is installed / used within CI be causing |
2b0e783
to
1771f70
Compare
Do you call somewhere We added the ability to hook on "clean" target. The easiest way to check "clean" targets are if env.GetOption("clean") or ("cleanall" in COMMAND_LINE_TARGETS):
env.Exit(0) |
1771f70
to
87d2b8e
Compare
Ahhhhh. We do use that in CI tests. Let me see if there is a way to detect it and then not run the environment check in that case. Hold on……… |
Thanks for the clue, Ivan! This is all we needed: |
a496b24
to
a93c0a5
Compare
8632989
to
4d03c25
Compare
82c7a22
to
3342c45
Compare
I see Neptune configurations were added by @EvilGremlin and @just-trey so if you don't mind me pinging you both, can you comment on whether this PR is actually needed, or if we are already sufficiently covered by using the MKS Robin board defines for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkyhead Elegoo has released a few different printers, and the boards are different. I know the original ones were clones of MKS boards, and those are what I have access to. I do not have access to the other boards, but I know BOARD_MKS_NEPTUNE_X and BOARD_MKS_NEPTUNE_3 are different. Hope this helps with your decision. I think they have a clone of the MKS 3.x board now as well.
52a9e5e
to
7e60d15
Compare
Does this also include support for the Neptune 3 Pro? |
Not at all, in fact this version of the Neptune 3 standard board doesn't work either which is why I abandoned it. Elegoo has bastardized Marlin too much to get the Neptune 3 working, this was my early attempt at getting it working on regular Marlin source code and it was a failure. As far as I know the source code for the pro and by extension the plus and the max hasn't been released yet and they use a different main board. |
@thinkyhead and @mlee12382 - I managed to get this diagram of the pins for the Neptune 3 Pro's board. Dunno if it'd be of any help to you, but I thought I'd share. |
a71a62c
to
250fd60
Compare
Additionally adding to this convo towards @mlee12382 & @kozross, was sifting through the Elegoo subreddit and found folks have been able to get klipper working. Here is the repo from someone within that community (@TheFeralEngineer): Hopefully that helps out with getting these printers supported. |
e4accf0
to
d657dfb
Compare
d657dfb
to
98643cb
Compare
98643cb
to
7bea4ce
Compare
Is anybody with these boards still interested in getting this in? From the comments it sounds like what is here is probably incomplete? I'd probably recommend closing this unless any contributors are still interested in getting them working...there isn't much point in pulling something in that isn't functional. |
7bea4ce
to
e25a925
Compare
c624e13
to
e6f1b07
Compare
e1aca3d
to
f9920d5
Compare
9c65146
to
4f65466
Compare
f9920d5
to
8a0ebc0
Compare
c792921
to
37fb26b
Compare
2e8b3fc
to
f4002de
Compare
37d77d6
to
aa44542
Compare
f4002de
to
9d15ec2
Compare
8d0d510
to
f6a8b06
Compare
1104ea2
to
a4d96e7
Compare
3e628a4
to
5ca5cd2
Compare
Co-Authored-By: Michael <89716126+mlee12382@users.noreply.github.com>
5ca5cd2
to
df64bb3
Compare
Revival of #24567 by @mlee12382 for evaluation and possible merge.
Description
Add new board definitions and pins and updated .ini files for platformio for the Elegoo Neptune series of printers.
Benefits
Adds boards to make custom compiling firmware for the Elegoo Neptune series of printers easier, duplicates and renames the 2 boards that come in the Neptune 2 printers to make it more straightforward and adds the missing board files for the Neptune X and Neptune 3