-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teensy 4.1 Ethernet support #19801
Add Teensy 4.1 Ethernet support #19801
Conversation
Bugfix 2.0.x
Sync upstream bugfix 2.0.x
Sync with upstream
Merge upstream
Merge upstream Bugfix 2.0.x
General cleanup. Fix SERIAL_BOTH.
Fix bug where attempts to write to telnetClient when no client is connected would cause a hang.
Echos MAC Address with Ethernet settings
I don't think this should be called ETHERNET_SUPPORT |
Personally I prefer the generic name, plus some sanity checks to warn the user that it is only supported by X. |
This implementation modifies serial.h, most Ethernet wouldn't need to do this... |
FYI, this type of implementation will likely not quite specific to only Teensy 4.1 in the future as should be same in all that use an NXP i.MX RT series MCU, or at least all i.MX RT series MCUs that have 10/100Mbps Ethernet (i.MX RT1060, i.MX RT1061, i.MX RT1062, i.MX RT1064, i.MX RT1050 and i.MX RT1020): |
Really? other MPU from the same series use the same ethernet, who would have though it.. What about all the other MPU's which vastly out number this one type? Citing two (1 and a wish-list) examples as your case to make it global, is not working for me. |
I've made some adjustments, the main one being that instead of enabling |
Fix loading ethernet settings from EEPROM. Remove trailing : when printing MAC Address. Don't print bogus MAC Address when ethernet is disabled.
@thinkyhead, I tested your changes. Everything seems to be working except reading the parameters from EEPROM. It gives this message: |
a694291
to
92767f5
Compare
Description
Add generic
M552
,M553
,M554
to set Ethernet parameters similar to other 3D printer firmware. Parameters can be saved to EEPROM.Adds Telnet server for Teensy 4.1 built-in Ethernet, which behaves like second serial port.
Benefits
Added functionality