Skip to content

Commit

Permalink
Fixup after bilsef's fix, revert SanityCheck for LINEAR_AXES >=5
Browse files Browse the repository at this point in the history
  • Loading branch information
DerAndere1 committed Sep 18, 2020
1 parent 09bb7ef commit 449f369
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 16 deletions.
18 changes: 9 additions & 9 deletions Marlin/Configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -833,18 +833,18 @@
* Override with M92
* X, Y, Z, [I ,[J ,[K ,]]] E0 [, E1[, E2...]]
*/
#define DEFAULT_AXIS_STEPS_PER_UNIT {LIST_N(LINEAR_AXES, 80, 80, 4000, 80, 80, 80), 500}
#define DEFAULT_AXIS_STEPS_PER_UNIT { 80, 80, 4000, 500 }

/**
* Default Max Feed Rate (mm/s)
* Override with M203
* X, Y, Z, [I ,[J ,[K ,]]] E0 [, E1[, E2...]]
*/
#define DEFAULT_MAX_FEEDRATE {LIST_N(LINEAR_AXES, 300, 300, 5, 300, 300, 300), 25 }
#define DEFAULT_MAX_FEEDRATE { 300, 300, 5, 25 }

//#define LIMITED_MAX_FR_EDITING // Limit edit via M203 or LCD to DEFAULT_MAX_FEEDRATE * 2
#if ENABLED(LIMITED_MAX_FR_EDITING)
#define MAX_FEEDRATE_EDIT_VALUES {LIST_N(LINEAR_AXES, 600, 600, 10, 600, 600, 600), 50 } // ...or, set your own edit limits
#define MAX_FEEDRATE_EDIT_VALUES { 600, 600, 10, 50 } // ...or, set your own edit limits
#endif

/**
Expand All @@ -853,11 +853,11 @@
* Override with M201
* X, Y, Z, [I ,[J ,[K ,]]] E0 [, E1[, E2...]]
*/
#define DEFAULT_MAX_ACCELERATION {LIST_N(LINEAR_AXES, 3000, 3000, 100, 3000, 3000, 3000), 10000 }
#define DEFAULT_MAX_ACCELERATION { 3000, 3000, 100, 10000 }

//#define LIMITED_MAX_ACCEL_EDITING // Limit edit via M201 or LCD to DEFAULT_MAX_ACCELERATION * 2
#if ENABLED(LIMITED_MAX_ACCEL_EDITING)
#define MAX_ACCEL_EDIT_VALUES {LIST_N(LINEAR_AXES, 6000, 6000, 200, 6000, 6000, 6000), 20000 } // ...or, set your own edit limits
#define MAX_ACCEL_EDIT_VALUES { 6000, 6000, 200, 20000 } // ...or, set your own edit limits
#endif

/**
Expand Down Expand Up @@ -885,15 +885,15 @@
#define DEFAULT_XJERK 10.0
#define DEFAULT_YJERK 10.0
#define DEFAULT_ZJERK 0.3
#define DEFAULT_IJERK 10.0
#define DEFAULT_JJERK 10.0
#define DEFAULT_KJERK 10.0
//#define DEFAULT_IJERK 0.3
//#define DEFAULT_JJERK 0.3
//#define DEFAULT_KJERK 0.3

//#define TRAVEL_EXTRA_XYJERK 0.0 // Additional jerk allowance for all travel moves

//#define LIMITED_JERK_EDITING // Limit edit via M205 or LCD to DEFAULT_aJERK * 2
#if ENABLED(LIMITED_JERK_EDITING)
#define MAX_JERK_EDIT_VALUES {LIST_N(LINEAR_AXES, 20, 20, 0.6, 20, 20, 20), 10 } // ...or, set your own edit limits
#define MAX_JERK_EDIT_VALUES { 20, 20, 0.6, 10 } // ...or, set your own edit limits
#endif
#endif

Expand Down
4 changes: 0 additions & 4 deletions Marlin/src/inc/SanityCheck.h
Original file line number Diff line number Diff line change
Expand Up @@ -1186,10 +1186,6 @@ static_assert(Y_MAX_LENGTH >= Y_BED_SIZE, "Movement bounds (Y_MIN_POS, Y_MAX_POS
#error "Please enable only one of DELTA, MORGAN_SCARA, COREXY, COREYX, COREXZ, COREZX, COREYZ, COREZY, ASYNC_SECONDARY_AXES or FOAMCUTTER_XYUV."
#endif

#if LINEAR_AXES >= 5
#error "LINEAR AXES >= 5 not yet supported, it causes unsafe movements. Developers should have a kill switch installed to stop movement before removing this check."
#endif

/**
* Delta requirements
*/
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/module/motion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const feedRate_t homing_feedrate_mm_s[LINEAR_AXES] PROGMEM = {
#endif
MMM_TO_MMS(HOMING_FEEDRATE_Z)
#if LINEAR_AXES >= 4
, MMM_TO_MMS(HOMING_FEEDRATE_I) // FIXME (DerAndere): Multiply with 4 as work-around for issue with internal feedrate
, MMM_TO_MMS(HOMING_FEEDRATE_I)
#endif
#if LINEAR_AXES >= 5
, MMM_TO_MMS(HOMING_FEEDRATE_J)
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/module/settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ void MarlinSettings::postprocess() {
// Unified Bed Leveling
//
{
_FIELD_TEST(planner_leveling_active);
_FIELD_TEST(planner_leveling_active); // FIXME (DerAndere): Too much data written to EEPROM since last _FIELD_TEST() causes Error: Field planner_leveling_active mismatch
const bool ubl_active = TERN(AUTO_BED_LEVELING_UBL, planner.leveling_active, false);
const int8_t storage_slot = TERN(AUTO_BED_LEVELING_UBL, ubl.storage_slot, -1);
EEPROM_WRITE(ubl_active);
Expand Down Expand Up @@ -1648,7 +1648,7 @@ void MarlinSettings::postprocess() {
// Unified Bed Leveling active state
//
{
_FIELD_TEST(planner_leveling_active);
_FIELD_TEST(planner_leveling_active); // FIXME (DerAndere): Too much data written to EEPROM since last _FIELD_TEST() causes Error: Field planner_leveling_active mismatch
#if ENABLED(AUTO_BED_LEVELING_UBL)
const bool &planner_leveling_active = planner.leveling_active;
const int8_t &ubl_storage_slot = ubl.storage_slot;
Expand Down

0 comments on commit 449f369

Please sign in to comment.