Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to annotation edit/delete in grading view #7314

Merged

Conversation

david-yz-liu
Copy link
Collaborator

@david-yz-liu david-yz-liu commented Nov 29, 2024

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

There are two bugs reported regarding annotation handling:

  1. The context menu's annotation "Edit" and "Delete" functionality isn't working
  2. Deleting a PDF annotation from the annotation table causes the PDF file to no longer render correctly (until refreshing the page).

This PR fixes both of those issues.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@david-yz-liu david-yz-liu force-pushed the fix-annotations-results-view branch from b2e6942 to 2a11eea Compare November 30, 2024 14:45
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12097259709

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 91.748%

Totals Coverage Status
Change from base Build 12089015708: -0.001%
Covered Lines: 41117
Relevant Lines: 44140

💛 - Coveralls

@david-yz-liu david-yz-liu added this to the v2.6.1 milestone Nov 30, 2024
@david-yz-liu david-yz-liu merged commit 8085877 into MarkUsProject:master Nov 30, 2024
5 of 6 checks passed
@david-yz-liu david-yz-liu deleted the fix-annotations-results-view branch November 30, 2024 16:49
david-yz-liu added a commit that referenced this pull request Dec 3, 2024
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Dec 6, 2024
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants