Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ta deletion #7304

Merged
merged 26 commits into from
Dec 6, 2024
Merged

Ta deletion #7304

merged 26 commits into from
Dec 6, 2024

Conversation

anubhajoshi01
Copy link
Contributor

@anubhajoshi01 anubhajoshi01 commented Nov 20, 2024

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Added functionality to give instructors the ability to delete TAs from courses on the Users/Graders tab. This involved adding a delete button on the actions menu, along with a destroy function on the controller. NOTE: A Ta cant be deleted if they have a note
...

Screenshots of your changes (if applicable) The new delete button Screenshot 2024-11-27 at 6 29 38 PM

After successful delete
Screenshot 2024-11-28 at 12 07 56 PM

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12189783975

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 90 of 91 (98.9%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.769%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/assets/javascripts/Components/ta_table.jsx 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
app/models/peer_review.rb 1 96.47%
spec/support/lti_controller_examples.rb 1 99.38%
app/controllers/peer_reviews_controller.rb 3 69.72%
Totals Coverage Status
Change from base Build 12097999442: 0.02%
Covered Lines: 41255
Relevant Lines: 44279

💛 - Coveralls

app/models/ta.rb Outdated Show resolved Hide resolved
app/controllers/tas_controller.rb Outdated Show resolved Hide resolved
compose.yaml Outdated Show resolved Hide resolved
config/locales/models/users/en.yml Outdated Show resolved Hide resolved
config/locales/views/users/en.yml Outdated Show resolved Hide resolved
spec/controllers/tas_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tas_controller_spec.rb Outdated Show resolved Hide resolved
app/models/annotation.rb Outdated Show resolved Hide resolved
app/assets/stylesheets/common/_markus.scss Outdated Show resolved Hide resolved
app/assets/javascripts/Components/ta_table.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anubhajoshi01 great job! I just left a few minor comments.

app/models/annotation.rb Show resolved Hide resolved
spec/support/annotation_shared_examples.rb Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@anubhajoshi01 anubhajoshi01 removed the request for review from david-yz-liu December 1, 2024 15:20
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anubhajoshi01 great work!

@david-yz-liu david-yz-liu merged commit 41685f7 into MarkUsProject:master Dec 6, 2024
6 checks passed
@david-yz-liu david-yz-liu added this to the v2.6.1 milestone Dec 6, 2024
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants