Marks Spreadsheet csv bug fix

[donny-wong]

Proposed Changes

In the grade_entry_form.rb file under the role TA, strangely one of the join queries when Rails translates to sql, it duplicates it:

INNER JOIN "grades" ON "grades"."grade_entry_student_id" = "grade_entry_students"."id"
INNER JOIN "grades" "grades_grade_entry_students_join" ON "grades_grade_entry_students_join"."grade_entry_student_id" = "grade_entry_students"."id"

This creates an incorrect grade_data result, thus the Marks Spreadsheet download has incorrect marks for students. Inserting raw SQL corrected this issue, however, it is not ideal.

...

Screenshots of your changes (if applicable)

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

[coveralls]

Pull Request Test Coverage Report for Build 11181724253

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
• 80 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.02%) to 91.651%

---

Files with Coverage Reduction	New Missed Lines	%
spec/controllers/submissions_controller_spec.rb	2	99.85%
app/models/course.rb	3	96.74%
app/models/group.rb	7	82.98%
app/controllers/submissions_controller.rb	68	79.9%

Totals
Change from base Build 11165241459:	0.02%
Covered Lines:	40656
Relevant Lines:	43687

---

💛 - Coveralls

[david-yz-liu]

@donny-wong my recommendation is to start with the equivalent query for the instructor role, then add a join to the grade_entry_students_tas table, and then filter for the ta_id being equal to the role_id.

When developing more complex ActiveRecord queries, the Rails console (rails c) is very useful for experimenting to get it right.