Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option to retain old grading data #7256

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Oct 3, 2024

Proposed Changes

Closes #5212.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

Within inline comments.

@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 5 times, most recently from d6f138d to 896d896 Compare October 8, 2024 02:59
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 5 times, most recently from 3658acb to 76e1739 Compare October 16, 2024 21:38
@pranavrao145 pranavrao145 marked this pull request as ready for review October 16, 2024 22:16
@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11958705999

Details

  • 236 of 237 (99.58%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 91.657%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/jobs/submissions_job.rb 23 24 95.83%
Totals Coverage Status
Change from base Build 11955265242: -0.04%
Covered Lines: 41062
Relevant Lines: 44117

💛 - Coveralls

@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 3 times, most recently from ce5d579 to aeadf2b Compare October 18, 2024 00:19
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch from 738cd52 to 19c19f7 Compare October 18, 2024 04:51
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 2 times, most recently from 1b64a1b to 295894a Compare October 18, 2024 15:47
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 2 times, most recently from 0af67d5 to 01e0d63 Compare October 24, 2024 04:49
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pranavrao145, great work! I just did a quick review of the back-end implementation and left some comments. Please work on those, and then I'll do another review in a few days.

app/jobs/submissions_job.rb Outdated Show resolved Hide resolved
app/jobs/submissions_job.rb Outdated Show resolved Hide resolved
@pranavrao145
Copy link
Contributor Author

pranavrao145 commented Oct 30, 2024

I'm just going to convert this back to a draft while I work on addressing comments just so it doesn't run tests on intermediate work, and I'll make it ready for review again once I'm finished!

EDIT: back to ready now, but Jest tests still wrongly failing

@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 3 times, most recently from 4478400 to 6bc11c5 Compare November 13, 2024 16:05
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch 2 times, most recently from 25d0cd8 to 3a15291 Compare November 14, 2024 23:16
@pranavrao145 pranavrao145 force-pushed the feat/retain-old-grading-data-option branch from 3a15291 to b6b69f8 Compare November 21, 2024 17:41
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavrao145 great job getting this completed! 🎉

@david-yz-liu david-yz-liu merged commit ecd5b52 into MarkUsProject:master Nov 23, 2024
4 of 6 checks passed
@pranavrao145 pranavrao145 deleted the feat/retain-old-grading-data-option branch November 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: do not overwrite existing fields on recollection
3 participants