Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make sure released submissions are not recollectable #7254

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Oct 2, 2024

Proposed Changes

This PR fixes a bug where released submissions were able to be manually collected from the repo browser page, despite not being able to be recollected on the submission browser page. Now, when the user attempts to recollect a submission on the repo browser that has already been released to students, an error message is flashed and the action is prevented.

Screenshot

image

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls
Copy link
Collaborator

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11165473377

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 91.638%

Totals Coverage Status
Change from base Build 11165241459: 0.004%
Covered Lines: 40585
Relevant Lines: 43616

💛 - Coveralls

Changelog.md Outdated Show resolved Hide resolved
spec/controllers/submissions_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/submissions_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/submissions_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/submissions_controller_spec.rb Outdated Show resolved Hide resolved
app/controllers/submissions_controller.rb Outdated Show resolved Hide resolved
@pranavrao145 pranavrao145 force-pushed the fix/released-submissions-recollectable branch from 6c4ee10 to 2b02a92 Compare October 3, 2024 15:59
@david-yz-liu david-yz-liu merged commit 8b23f9d into MarkUsProject:master Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants