-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make sure released submissions are not recollectable #7254
Merged
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pranavrao145:fix/released-submissions-recollectable
Oct 4, 2024
Merged
Fix: Make sure released submissions are not recollectable #7254
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pranavrao145:fix/released-submissions-recollectable
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11165473377Details
💛 - Coveralls |
david-yz-liu
reviewed
Oct 3, 2024
david-yz-liu
reviewed
Oct 3, 2024
pranavrao145
force-pushed
the
fix/released-submissions-recollectable
branch
from
October 3, 2024 15:59
6c4ee10
to
2b02a92
Compare
…issions-recollectable
david-yz-liu
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes a bug where released submissions were able to be manually collected from the repo browser page, despite not being able to be recollected on the submission browser page. Now, when the user attempts to recollect a submission on the repo browser that has already been released to students, an error message is flashed and the action is prevented.
Screenshot
Type of Change
Checklist
Before opening your pull request:
After opening your pull request: