Bugfix: allow annotations on parent assignments with released peer reviews

[pretendWhale]

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Currently, if a submission has a released peer review, the annotation validations prevent adding new annotations on the result in the parent assignment. This is a bug, which this PR fixes. Resolves #7184
...

Screenshots of your changes (if applicable)

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

[coveralls]

Pull Request Test Coverage Report for Build 11016940797

Details

• 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
• 1913 unchanged lines in 60 files lost coverage.
• Overall coverage decreased (-0.002%) to 91.594%

---

Files with Coverage Reduction	New Missed Lines	%
app/lib/markus_logger.rb	1	71.93%
config/dummy_lti_config.rb	1	66.67%
config/initializers/01_init_app.rb	1	50.0%
spec/factories/groups.rb	1	66.67%
config/initializers/resque.rb	2	84.62%
spec/factories/annotations.rb	2	92.86%
spec/factories/flexible_criteria.rb	2	84.62%
spec/factories/grouping_starter_file_entries.rb	2	80.0%
spec/factories/marking_scheme.rb	2	77.78%
spec/factories/rubric_criteria.rb	2	81.82%

Totals
Change from base Build 10984933494:	-0.002%
Covered Lines:	40506
Relevant Lines:	43551

---

💛 - Coveralls

[david-yz-liu]

I'm not convinced another check is necessary. Can't we modify line 65 to use non_pr_results?

[pretendWhale]

@david-yz-liu Thanks! I think you are correct, and in fact this logic is better.