Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only retain most recent test results #7214

Merged

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Sep 12, 2024

Proposed Changes

Fixes #7070 by making the "Download Test Results" button on the Summary page look at the latest test run to determine for which test groups the results must be downloaded, and downloads them accordingly. So, if a user deletes a test group and runs the tests again, the next summary would not contain the deleted test groups. This is in contrast to the original behaviour, where the latest results of every test group would always be part of the JSON/CSV summary.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls
Copy link
Collaborator

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10926756567

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1886 unchanged lines in 60 files lost coverage.
  • Overall coverage increased (+0.001%) to 91.542%

Files with Coverage Reduction New Missed Lines %
app/lib/markus_logger.rb 1 71.93%
config/dummy_lti_config.rb 1 66.67%
config/initializers/01_init_app.rb 1 50.0%
spec/factories/groups.rb 1 66.67%
config/initializers/resque.rb 2 83.33%
spec/factories/annotations.rb 2 92.86%
spec/factories/flexible_criteria.rb 2 84.62%
spec/factories/grouping_starter_file_entries.rb 2 80.0%
spec/factories/marking_scheme.rb 2 77.78%
spec/factories/rubric_criteria.rb 2 81.82%
Totals Coverage Status
Change from base Build 10914123718: 0.001%
Covered Lines: 40318
Relevant Lines: 43372

💛 - Coveralls

@pranavrao145 pranavrao145 force-pushed the feat/most-recent-test-results branch from b9dbcba to cf0dc3d Compare September 18, 2024 02:33
@pranavrao145 pranavrao145 marked this pull request as ready for review September 18, 2024 02:35
@pranavrao145 pranavrao145 force-pushed the feat/most-recent-test-results branch from 06c9738 to 7f489d8 Compare September 18, 2024 03:07
@pranavrao145 pranavrao145 force-pushed the feat/most-recent-test-results branch from 7f489d8 to 8ee4f5d Compare September 18, 2024 03:07
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavrao145 great job! I left just a few comments to help improve the queries.

app/models/assignment.rb Show resolved Hide resolved
app/models/assignment.rb Outdated Show resolved Hide resolved
app/models/assignment.rb Outdated Show resolved Hide resolved
@pranavrao145 pranavrao145 force-pushed the feat/most-recent-test-results branch from 79e24bd to 0cab2b0 Compare September 18, 2024 16:16
@pranavrao145 pranavrao145 force-pushed the feat/most-recent-test-results branch from 0cab2b0 to 41cd6d5 Compare September 18, 2024 17:00
@david-yz-liu david-yz-liu merged commit 89fc20e into MarkUsProject:master Sep 18, 2024
6 checks passed
@david-yz-liu david-yz-liu added this to the v2.5.2 milestone Sep 18, 2024
pretendWhale pushed a commit to pretendWhale/Markus that referenced this pull request Sep 25, 2024
…sProject#7214)

* feat(most-recent-test-results): fixed JSON/CSV summary of tests to only have results from latest test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download most recent test results
3 participants