-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: only retain most recent test results #7214
Fix: only retain most recent test results #7214
Conversation
Pull Request Test Coverage Report for Build 10926756567Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
a8cfd42
to
d484888
Compare
d484888
to
6d075d1
Compare
575cca9
to
baec906
Compare
…ly have results from latest test run
…rom latest test group
b9dbcba
to
cf0dc3d
Compare
06c9738
to
7f489d8
Compare
…esults summary fix
7f489d8
to
8ee4f5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavrao145 great job! I left just a few comments to help improve the queries.
79e24bd
to
0cab2b0
Compare
0cab2b0
to
41cd6d5
Compare
…sProject#7214) * feat(most-recent-test-results): fixed JSON/CSV summary of tests to only have results from latest test run
Proposed Changes
Fixes #7070 by making the "Download Test Results" button on the Summary page look at the latest test run to determine for which test groups the results must be downloaded, and downloads them accordingly. So, if a user deletes a test group and runs the tests again, the next summary would not contain the deleted test groups. This is in contrast to the original behaviour, where the latest results of every test group would always be part of the JSON/CSV summary.
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: