Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign tas final #7179

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Conversation

AinaMerch
Copy link
Contributor

@AinaMerch AinaMerch commented Aug 9, 2024

Proposed Changes

Add functionality to assign TAs to specific sections:
Add a new button to the graders page called "Assign by Section".
When the button is clicked, open a new modal that has a form that displays a list of all course sections, and next to each section is a dropdown with a list of TAs (plus an "empty" option). So, each section can be assigned at most one TA using this form. [If an instructor wants to assign multiple TAs to the same section, they'll need to submit the form multiple times.]
When the form is submitted, the controller assigns the TAs to all groups in their assigned sections. Note that all existing TA assignments remain unchanged; this form only adds new TA assignments.

...

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)
I can't figure out how to get the right query to filter groupings by sections

@AinaMerch AinaMerch requested a review from david-yz-liu August 27, 2024 06:14
@david-yz-liu david-yz-liu marked this pull request as ready for review September 18, 2024 13:35
@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2024

Pull Request Test Coverage Report for Build 10928790259

Details

  • 86 of 113 (76.11%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 91.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/graders_controller.rb 35 37 94.59%
app/assets/javascripts/Components/graders_manager.jsx 2 7 28.57%
app/assets/javascripts/Components/Modals/section_distribution_modal.js 2 22 9.09%
Files with Coverage Reduction New Missed Lines %
app/assets/javascripts/Components/graders_manager.jsx 1 37.4%
Totals Coverage Status
Change from base Build 10928761298: -0.04%
Covered Lines: 40492
Relevant Lines: 43537

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 0a03ff5 into MarkUsProject:master Sep 18, 2024
1 of 2 checks passed
@david-yz-liu david-yz-liu added this to the v2.5.2 milestone Sep 18, 2024
pretendWhale pushed a commit to pretendWhale/Markus that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants