-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign tas final #7179
Merged
david-yz-liu
merged 11 commits into
MarkUsProject:master
from
AinaMerch:assign-tas-final
Sep 18, 2024
Merged
Assign tas final #7179
david-yz-liu
merged 11 commits into
MarkUsProject:master
from
AinaMerch:assign-tas-final
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10928790259Details
💛 - Coveralls |
david-yz-liu
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add functionality to assign TAs to specific sections:
Add a new button to the graders page called "Assign by Section".
When the button is clicked, open a new modal that has a form that displays a list of all course sections, and next to each section is a dropdown with a list of TAs (plus an "empty" option). So, each section can be assigned at most one TA using this form. [If an instructor wants to assign multiple TAs to the same section, they'll need to submit the form multiple times.]
When the form is submitted, the controller assigns the TAs to all groups in their assigned sections. Note that all existing TA assignments remain unchanged; this form only adds new TA assignments.
...
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
I can't figure out how to get the right query to filter groupings by sections