Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the token generation due date place-holder #7128

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

umututku03
Copy link
Contributor

Proposed Changes

This pull request updates the student interface for automated tests. If the instructor(s) did not specify the Token End Date, the placeholder will be the Assignment Deadline.

  1. View Updates:
    • Ensured that the assignment deadline is used as a placeholder if token_end_date is not present.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • [] I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • [] I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • [] I have verified that the CI tests have passed.
  • [] I have reviewed the test coverage changes reported by Coveralls.
  • [] I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)
N/A

@coveralls
Copy link
Collaborator

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9715266789

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.396%

Totals Coverage Status
Change from base Build 9689379709: 0.0%
Covered Lines: 40103
Relevant Lines: 43198

💛 - Coveralls

@umututku03 umututku03 requested a review from david-yz-liu June 29, 2024 03:14
@umututku03 umututku03 changed the title adding the token generation duedate placeholder Adding the token generation due date place-holder Jun 29, 2024
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the changelog (this is a bug fix since the page was failing to load previously).

app/views/automated_tests/student_interface.html.erb Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jul 13, 2024

Pull Request Test Coverage Report for Build 9984723471

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.414%

Totals Coverage Status
Change from base Build 9912724956: 0.0%
Covered Lines: 40148
Relevant Lines: 43246

💛 - Coveralls

@umututku03 umututku03 requested a review from david-yz-liu July 13, 2024 00:44
@umututku03 umututku03 requested a review from david-yz-liu July 18, 2024 03:15
@david-yz-liu david-yz-liu merged commit d284594 into MarkUsProject:master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants