-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotester Token Generation Time #7127
Autotester Token Generation Time #7127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umututku03 in addition to my inline comments, you should redo the pull request description, as you have removed parts under the "description" section and have some formatting errors in the checklist. Note that since this is a user-facing change screenshots should be included.
Also, there is a failing test.
…t next token generation time
Pull Request Test Coverage Report for Build 10086959334Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umututku03 looking good: the logic has been simplified and my previous comments addressed. I left a more detailed review, including UI-related items. After addressing these, please update the screenshot in the PR description as well. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umututku03 great work on this! 🎉
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This enhancement aims to help students know exactly when they can expect the next token to be available, providing clarity and better planning for their test runs. Currently, the system shows - tokens available on, tokens regenerate after and token available. The goal is to calculate and display the exact future time when the next token will be generated based on the current token regeneration period and the last token generation time. We refactored the
AutomatedTestsController
to improve error handling and robustly calculate thenext_token_generation_time
, added new I18n keys for better user messaging, and ensured all keys are used correctly to avoid non-normalized keys. The frontend interface was updated to display these messages clearly, informing students about next token generation time.Resolves #7071.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)