Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not overwrite max_mark in grade summary #7125

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jun 24, 2024

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

There is currently a bug with display of extra marks on the grade summary page. When iterating over the collection of results, with percentage extra_mark's, a variable max_mark is set equal to the maximum mark for the current result. In the next loop iteration this value for max_mark will be used, and the current result's max_mark will not be used. This is fine when all results are for the same assignment, but leads to incorrectly calculated extra_mark's when the collection of results is from multiple assignments: only every other grade will be calculated correctly.

Screenshots of your changes (if applicable)
Associated [documentation repository](https://github.com/MarkUsProject/Wiki) pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@pretendWhale pretendWhale marked this pull request as ready for review June 25, 2024 15:38
@pretendWhale pretendWhale requested a review from donny-wong June 25, 2024 16:02
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9665487788

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.392%

Totals Coverage Status
Change from base Build 9528555904: 0.006%
Covered Lines: 40079
Relevant Lines: 43174

💛 - Coveralls

@donny-wong donny-wong requested a review from david-yz-liu June 25, 2024 18:54
@david-yz-liu david-yz-liu added this to the v2.4.12 milestone Jun 26, 2024
@david-yz-liu david-yz-liu merged commit b0650c6 into MarkUsProject:master Jun 26, 2024
8 checks passed
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants