-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text annotation #7081
Text annotation #7081
Conversation
Pull Request Test Coverage Report for Build 9259697777Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umututku03 good job! In addition to the inline comments I left, please make sure to add yourself to the list of contributors.
@@ -6,6 +6,7 @@ | |||
|
|||
### ✨ New features and improvements | |||
|
|||
- Added validations to the `TextAnnotation` model to ensure `line_start` and `line_end` are >= 1, and `column_start` and `column_end` are >= 0. (#7081) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add entries to the bottom of the list (within each subsection)
Proposed Changes
This pull request adds new validations to the
TextAnnotation
model and updates the corresponding tests to ensure data integrity. Specifically, it ensures that:line_start
andline_end
attributes must be greater than or equal to 1.column_start
andcolumn_end
attributes must be greater than or equal to 0.Motivation
These changes are motivated by the need to prevent invalid values for line and column numbers in the
TextAnnotation
model, ensuring that the data stored is always within a valid range. This enhancement improves the robustness and reliability of the application.Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments