-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Progress Bar to File Upload Modal #7078
Merged
david-yz-liu
merged 12 commits into
MarkUsProject:master
from
pranavrao145:feat/file-upload-progress-bar
May 24, 2024
Merged
Add Progress Bar to File Upload Modal #7078
david-yz-liu
merged 12 commits into
MarkUsProject:master
from
pranavrao145:feat/file-upload-progress-bar
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavrao145
force-pushed
the
feat/file-upload-progress-bar
branch
4 times, most recently
from
May 17, 2024 04:58
a417bff
to
1d3e202
Compare
pranavrao145
commented
May 17, 2024
app/assets/javascripts/Components/__tests__/submission_file_manager.test.jsx
Show resolved
Hide resolved
pranavrao145
force-pushed
the
feat/file-upload-progress-bar
branch
2 times, most recently
from
May 17, 2024 05:04
e57ac79
to
aa812b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavrao145 great job. Regarding the failing tests, sadly it's not an issue on your end, and I just made a PR to fix it. Update your branch from the latest master and the tests should be fixed.
app/assets/javascripts/Components/Modals/submission_file_upload_modal.jsx
Show resolved
Hide resolved
pranavrao145
force-pushed
the
feat/file-upload-progress-bar
branch
2 times, most recently
from
May 23, 2024 05:12
9c340db
to
93facef
Compare
…o prefix for submission_file_upload_modal
pranavrao145
force-pushed
the
feat/file-upload-progress-bar
branch
from
May 23, 2024 05:12
93facef
to
22738c1
Compare
Pull Request Test Coverage Report for Build 9202569520Details
💛 - Coveralls |
david-yz-liu
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #5401 by adding a progress bar to the file upload modal on the submissions page.
Screenshot
The progress bar is hard to catch in action, but here is a screenshot of what it looks like moments before the modal itself closes (i.e. once the file has been completely uploaded):
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
Before opening your pull request:
After opening your pull request: