Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Progress Bar to File Upload Modal #7078

Merged

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented May 12, 2024

Proposed Changes

Closes #5401 by adding a progress bar to the file upload modal on the submissions page.

Screenshot

The progress bar is hard to catch in action, but here is a screenshot of what it looks like moments before the modal itself closes (i.e. once the file has been completely uploaded):

image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@pranavrao145 pranavrao145 force-pushed the feat/file-upload-progress-bar branch 4 times, most recently from a417bff to 1d3e202 Compare May 17, 2024 04:58
@pranavrao145 pranavrao145 force-pushed the feat/file-upload-progress-bar branch 2 times, most recently from e57ac79 to aa812b9 Compare May 17, 2024 05:04
@pranavrao145 pranavrao145 marked this pull request as ready for review May 17, 2024 05:06
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavrao145 great job. Regarding the failing tests, sadly it's not an issue on your end, and I just made a PR to fix it. Update your branch from the latest master and the tests should be fixed.

@pranavrao145 pranavrao145 force-pushed the feat/file-upload-progress-bar branch 2 times, most recently from 9c340db to 93facef Compare May 23, 2024 05:12
@pranavrao145 pranavrao145 force-pushed the feat/file-upload-progress-bar branch from 93facef to 22738c1 Compare May 23, 2024 05:12
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9202569520

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.423%

Totals Coverage Status
Change from base Build 9165923791: 0.05%
Covered Lines: 40000
Relevant Lines: 43079

💛 - Coveralls

@pranavrao145 pranavrao145 requested a review from david-yz-liu May 23, 2024 13:47
@david-yz-liu david-yz-liu merged commit d521451 into MarkUsProject:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add feedback when documents are being uploaded
3 participants