Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAs See Starter Files #6996

Merged

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Mar 22, 2024

Motivation and Context

Closes #5137. If an assignment has several starter file groups, there is a possibility that different students can have different starter files. However the grading TA cannot currently see information about starter files, so they cannot tell which files are assigned to whom. This PR aims to fix this.

Your Changes

  • Change Rails policies to allow TAs to access starter-file-related routes.
  • Add a "read-only" mode to the assignment starter file page, which TAs will see if they do not have permission to edit. This includes permission to download starter file mappings, which they can use to see who is assigned what starter file.

Type of change (select all that apply):

  • New feature (non-breaking change which adds functionality)

Testing

  • Changed existing RSpec policy tests for routes that were changed.
  • Wrote a suite of Jest tests to test the behaviour of the disabling/enabling of buttons on readOnly mode for the Starter File page.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the Changelog.md file.
  • I have made changes to the documentation and linked to that pull request below.

Pull request to make documentation changes (if applicable)

MarkUsProject/Wiki#207

@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch 5 times, most recently from b46b9b2 to 27ba34b Compare March 23, 2024 06:46
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from 27ba34b to 3f9a7c6 Compare March 23, 2024 06:46
@pranavrao145 pranavrao145 marked this pull request as ready for review March 23, 2024 06:48
@coveralls
Copy link
Collaborator

coveralls commented Mar 23, 2024

Pull Request Test Coverage Report for Build 8493244503

Details

  • 52 of 52 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.849%

Totals Coverage Status
Change from base Build 8487186587: -0.1%
Covered Lines: 40082
Relevant Lines: 42992

💛 - Coveralls

@pranavrao145 pranavrao145 marked this pull request as draft March 23, 2024 16:33
@pranavrao145 pranavrao145 marked this pull request as ready for review March 23, 2024 16:41
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from b213d67 to 46eabef Compare March 23, 2024 16:46
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from 46eabef to 9569872 Compare March 23, 2024 16:47
app/policies/assignment_policy.rb Outdated Show resolved Hide resolved
app/policies/starter_file_group_policy.rb Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from 8b1258b to 8aac9df Compare March 27, 2024 02:18
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from 017c173 to 585e844 Compare March 27, 2024 03:48
@pranavrao145 pranavrao145 force-pushed the feat/tas-see-starter-files branch from 82296a8 to 5cf8143 Compare March 30, 2024 20:34
@david-yz-liu david-yz-liu merged commit fcf0378 into MarkUsProject:master Mar 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: View assigned student starter files when grading
3 participants