Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login_spec.rb flaky test on GitHub Actions run #6966

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

Bruce-8
Copy link
Contributor

@Bruce-8 Bruce-8 commented Feb 28, 2024

Motivation and Context

Currently, there is an issue with the MarkUs Tests / test (pull_request) where the test job contains a flaky test, which is the rspec ./spec/system/main/login_spec.rb:24 # logging in Admin User signs in and redirects to the admin page test. This pull request attempts to address this issue.

Your Changes

Description: Modified the login_spec.rb file by passing ignore_query: true to the have_current_path method. An example of the failing test can be found by accessing this this workflow.

Type of change (select all that apply):

  • Test update (change that modifies or updates tests only)

Testing

  • Manually tested this change by running the MarkUs Tests / test (pull_request) GitHub Action to check if all tests have passed.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have updated the Changelog.md file.

Pull request to make documentation changes (if applicable)

@Bruce-8 Bruce-8 changed the title Fixed flaky test on workflow run Fixed login_spec.rb flaky test on Github Actions run Feb 28, 2024
@Bruce-8 Bruce-8 changed the title Fixed login_spec.rb flaky test on Github Actions run Fixed login_spec.rb flaky test on GitHub Actions run Feb 28, 2024
@Bruce-8 Bruce-8 marked this pull request as ready for review February 28, 2024 09:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8077760378

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.771%

Totals Coverage Status
Change from base Build 8068166628: 0.0%
Covered Lines: 39137
Relevant Lines: 42024

💛 - Coveralls

@Bruce-8 Bruce-8 requested a review from david-yz-liu February 28, 2024 09:24
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bruce-8 thanks!

@david-yz-liu david-yz-liu merged commit c825d6a into MarkUsProject:master Mar 3, 2024
8 checks passed
@Bruce-8 Bruce-8 deleted the fix-loginspec-error branch March 4, 2024 22:40
AinaMerch pushed a commit to AinaMerch/Markus that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants