Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net::http import to lti_helper #6909

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jan 16, 2024

Motivation and Context

In production mode, the net/http module is not loaded by default in jobs/helpers. In contrast, net/http is loaded by default in development. This PR adds an explicit require 'net/http' invocation to lti_helper.rb similar to automated_tests_helper.rb.

Your Changes

Description:
Add require to lti_helper.rb

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested in our staging environment on ben - because NET::HTTP is loaded on development, it works there without issue.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

Pull request to make documentation changes (if applicable)

@pretendWhale pretendWhale added this to the v2.4.3 milestone Jan 16, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7547851117

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.68%

Totals Coverage Status
Change from base Build 7544170828: 0.0%
Covered Lines: 38761
Relevant Lines: 41657

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 58cd1d5 into MarkUsProject:master Jan 17, 2024
6 checks passed
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants