Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fontawesome import to peer review table #6908

Merged

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jan 15, 2024

Motivation and Context

Previously fontawesomeicons were not being explicitly imported into peer_review_table.jsx, which caused rendering of the table to fail. This PR adds the import explicitly

Your Changes

Description:
Add fontawesome icon import

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested in browser that the table does not load without the import, but does load with the import.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have updated the Changelog.md file.

@donny-wong donny-wong added this to the v2.4.3 milestone Jan 15, 2024
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pretendWhale please update the Changelog

@david-yz-liu david-yz-liu merged commit 03fe12e into MarkUsProject:master Jan 16, 2024
6 checks passed
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants