Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotest fixes #6907

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

david-yz-liu
Copy link
Collaborator

@david-yz-liu david-yz-liu commented Jan 14, 2024

Motivation and Context

There were two bugs related to autotesting that instructors (and I) encountered.

  1. The autotest settings client-side validation was (sometimes) reporting an error when a criterion was not selected for a test group.
  2. Test groups that were timing out were still causing marks to be set for their associated criteria. (I encountered this as a consequence of testing Improve default error message when a test group times out markus-autotesting#471.

Your Changes

Description:

  1. Ensured that a criterion value of null is permitted in the form. This replaces the old '' default value; this is consistent with the data pulled from the database, which has each test group object's criterion_id set to nil (not ''). I think this was the cause of the flakiness of this error.
    • Also, modified the criterion label to 'N/A' to better communicate what a blank value means.
  2. Improve the check for timed-out test group results. Note that the previous code used .slice to check for specific error type values; I've modified this to look for any specified error type.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested manually. Added test cases for the second change.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the Changelog.md file.

@david-yz-liu david-yz-liu added this to the v2.4.3 milestone Jan 14, 2024
@donny-wong donny-wong requested review from pretendWhale and removed request for donny-wong January 16, 2024 20:23
@pretendWhale pretendWhale merged commit a9b8c8c into MarkUsProject:master Jan 17, 2024
6 checks passed
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Jan 17, 2024
* Fix autotest settings validation bug when criterion is null

* Ensure autotested criteria do not have marks set if tests time out
@david-yz-liu david-yz-liu deleted the autotest-fixes branch August 9, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants