Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lti settings route #6903

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Jan 11, 2024

Motivation and Context

Your Changes

Description:
One of the routes (assignment/lti_settings) was not properly configured in routes.rb. This adds the route properly, as well as fixing an i18n syntax error.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested that the route was working in browser, including posting new line items

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@pretendWhale pretendWhale added this to the v2.4.2 milestone Jan 11, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7504416930

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 91.68%

Totals Coverage Status
Change from base Build 7464283474: 0.001%
Covered Lines: 38760
Relevant Lines: 41656

💛 - Coveralls

@pretendWhale pretendWhale merged commit 86f678a into MarkUsProject:master Jan 12, 2024
6 checks passed
donny-wong added a commit to donny-wong/Markus that referenced this pull request Jan 12, 2024
* adding lti settings route

* normalized I18n

---------

Co-authored-by: Donny Wong <donnywong@cs.toronto.edu>
@donny-wong donny-wong deleted the lti_settings_route branch April 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants