Use websockets to display autotest run errors #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7250454142
💛 - Coveralls |
8bee671 to
9fe42ba
Compare
Also improve display of autotest run status in general by differentiating between AutotestRunJob and AutotestResultsJob completing. Also add websocket support for autotest results to submission table.
9fe42ba to
48f70e7
Compare
pretendWhale
approved these changes
Jan 4, 2024
donny-wong
pushed a commit
to donny-wong/Markus
that referenced
this pull request
Jan 12, 2024
Also improve display of autotest run status in general by differentiating between AutotestRunJob and AutotestResultsJob completing. Also add websocket support for autotest results to submission table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently if there is an autotest setup error (e.g., an error in package installation), the autotests fail to run, but no error message is displayed until the page is refreshed.
Your Changes
Description: Modified the
AutotestRunJobso that it reports errors using websockets. This ensures the error messages are displayed in real-time.Because I removed the old error flash message, I also modified the submissions table to use websockets to track autotesting status. This required updating the
AutotestRunJobandAutotestResultsJobto broadcast messages for both individual and batch test runs.Type of change (select all that apply):
Testing
Tested manually in the UI for both instructor-run (individual and batch) and student-run tests.
Questions and Comments (if applicable)
Checklist