Feedback Files: Ensure submission association if it exists #6875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
the API
feedback_files.index
method currently does not return any feedback files, because it callssubmission.feedback_files
but feedback files are not currently associated with submissions directly. This PR adds that association, if a submission exists for the test run.Your Changes
Description:
Modified
test_run.update_results!
to add submission association if one exists.Type of change (select all that apply):
Testing
Tested via the
markusapi
package, as well as adding tests.Questions and Comments (if applicable)
If a submission exists when test results are processed, marks are created due to a call to
set_autotest_marks
inupdate_results!
, even if the tests have failed. I don't think this is a problem, but there may be cases I'm not considering.Checklist