Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Files: Ensure submission association if it exists #6875

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Dec 14, 2023

Motivation and Context

the API feedback_files.index method currently does not return any feedback files, because it calls submission.feedback_files but feedback files are not currently associated with submissions directly. This PR adds that association, if a submission exists for the test run.

Your Changes

Description:
Modified test_run.update_results! to add submission association if one exists.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested via the markusapi package, as well as adding tests.

Questions and Comments (if applicable)

If a submission exists when test results are processed, marks are created due to a call to set_autotest_marks in update_results!, even if the tests have failed. I don't think this is a problem, but there may be cases I'm not considering.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the Changelog.md file.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7227088947

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.565%

Totals Coverage Status
Change from base Build 7226755465: 0.003%
Covered Lines: 38550
Relevant Lines: 41480

💛 - Coveralls

@david-yz-liu david-yz-liu added this to the v2.4.2 milestone Dec 18, 2023
@donny-wong donny-wong requested review from david-yz-liu and removed request for david-yz-liu December 19, 2023 03:41
@david-yz-liu david-yz-liu merged commit d88756c into MarkUsProject:master Jan 4, 2024
2 checks passed
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants