-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with LTI launch while logged in and course creation #6835
Merged
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pretendWhale:lti-login-bugfixes
Jan 9, 2024
Merged
Fix issues with LTI launch while logged in and course creation #6835
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pretendWhale:lti-login-bugfixes
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7463603247Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
donny-wong
approved these changes
Jan 8, 2024
david-yz-liu
reviewed
Jan 9, 2024
david-yz-liu
approved these changes
Jan 9, 2024
donny-wong
pushed a commit
to donny-wong/Markus
that referenced
this pull request
Jan 12, 2024
* fix issue with lti launch while logged in and new course with existing name * make lti routes available in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Two bugs were discovered with lti functionality:
choose_course
pathYour Changes
Description:
login
method to properly redirect logged-in users.Type of change (select all that apply):
Testing
Wrote tests for the changed methods, and tested in the web interface.
Questions and Comments (if applicable)
Checklist
Pull request to make documentation changes (if applicable)