This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Change directory structure for repo merge #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Other, please explain:
first of a series of PRs to change overall developer / maintainer workflow by merging this repo with the main /markbind repo, as discussed in
MarkBind/markbind#411
MarkBind/markbind#981
What is the rationale for this request?
To allow for a clean merge of this repo into the main /markbind repo, we need to ensure the directory structure dosen't conflict.
What changes did you make? (Give an overview)
Moved all appropriate files under
frontend/components
directory. (except.gitignore
, and previously already gitignored files (e.g.node_modules
))Is there anything you'd like reviewers to focus on?
merge /vue-strap's upstream into my /markbind's originmake a pr from my /markbind's origin to upstream(not so sure if history is preserved this way)Testing instructions:
na
Proposed commit message: (wrap lines at 72 characters)
Change directory structure for repo merge
Markbind's vue component definitions are stored in the vue-strap fork.
This has some implications on development and maintainer workflow (see
issue yuche#411 for more detail), most notably needing to manually copy the
minified bundle to test changes in /vue-strap.
An alternative was raised in issue #981 to alleviate this, that is to
make /vue-strap a scoped package. This still has several drawbacks as
compared to a complete repo merge as outlined in yuche#411, such as needing
to run tests on both repos.
Hence, let's prepare the directory structure of the vue-strap fork
to allow for a clean merge into the /markbind repo, preserving
the commit history of /vue-strap.