This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Remove page-front class from dropdown and typeahead #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page-front class was added to increase the z-index in order to fix the issue of them being positioned below the page navigations. The root cause of the page navigations being positioned above the dropdown and typeahead has been identified to be the sticky-top class added to the page navigations which increases the z-index unnecessarily. The sticky-top class will be removed from the side navigations. Let's remove the page-front class from the dropdown and typeahead components now that they are no longer necessary.
f7881a0 to
9b4a984
Compare
Chng-Zhi-Xuan
approved these changes
Apr 10, 2019
yamgent
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page-front class was added in #103 and #101 to increase the z-index in order to fix the issue of them being positioned below the page navigations after changes in MarkBind/markbind#733.
The root cause of the page navigations being positioned above the dropdown and typeahead has been identified to be the sticky-top class added to the page navigations which increases the z-index unnecessarily. The sticky-top class will be removed from the side navigations in MarkBind/markbind#827.
Let's remove the page-front class from the dropdown and typeahead components now that they are no longer necessary.