Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MarkBind's website to markbind.github.io #699

Merged
merged 3 commits into from
Feb 19, 2019

Conversation

amad-person
Copy link
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Other, please explain:

Deploy the MarkBind website to https://markbind.github.io/ instead of a redirect.

Fixes #626.
Part of #662.

What is the rationale for this request?

Currently, https://markbind.github.io redirects to https://markbind.github.io/markbind/.
These changes will deploy the released version of the MarkBind website directly to https://markbind.github.io instead.

What changes did you make? (Give an overview)

Changes made to site.json:

"baseUrl": "/"
  "deploy": {
    "message": "Site Update.",
    "repo": "https://github.com/MarkBind/markbind.github.io.git",
    "branch": "master"
  }

Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary* tested in on our actual site, seems to work after a minor change which I commented.

EDIT: *Temporary because there's a URL conflict right now, see: MarkBind/markbind.github.io@efb7168.

docs/site.json Outdated
@@ -1,5 +1,5 @@
{
"baseUrl": "/markbind",
"baseUrl": "/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "baseUrl": "", otherwise markbind build will throw an error.

@yamgent yamgent added this to the v1.19.1 milestone Feb 18, 2019
@damithc
Copy link
Contributor

damithc commented Feb 18, 2019

Temporary because there's a URL conflict right now

Oops. What can we do about this? I don't think renaming markbind repo will help as GitHub remembers the old name as well. Rename the generated markbind folder to something else?

@yamgent
Copy link
Member

yamgent commented Feb 19, 2019

Oops. What can we do about this? I don't think renaming markbind repo will help as GitHub remembers the old name as well. Rename the generated markbind folder to something else?

If I am not wrong, we should be able to just disable this repo's website when the time for actual deployment comes and it should work. EDIT: Right now the problem is having two active sites at the same time, which is why I reverted it after testing this PR out.

@yamgent yamgent changed the title Deploy MarkBind website to markbind.github.io Migrate MarkBind website to markbind.github.io Feb 19, 2019
@yamgent yamgent changed the title Migrate MarkBind website to markbind.github.io Migrate MarkBind's website to markbind.github.io Feb 19, 2019
@yamgent yamgent merged commit b3e2d78 into MarkBind:master Feb 19, 2019
@damithc
Copy link
Contributor

damithc commented Feb 19, 2019

If I am not wrong, we should be able to just disable this repo's website when the time for actual deployment comes and it should work. EDIT: Right now the problem is having two active sites at the same time, which is why I reverted it after testing this PR out.

I see. That means we'll have to host dev docs at another repo (when we convert them to MarkBind) as the markbind site cannot have an active site.

@amad-person amad-person deleted the deploy-markbind-github-io branch December 7, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants