Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically convert GitHub-based projects into MarkBind websites #698
Automatically convert GitHub-based projects into MarkBind websites #698
Changes from all commits
aab2b08
d27f30d
601c057
f12f8f2
9936675
c469a69
0688682
1bbfdd2
8ccc077
8e05778
92a521c
ca3508e
b0ee811
ca1fb8b
93cb7e4
c00f757
3f4440e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that, if an author calls
markbind init -c
on an existing site (could be by accident),_markbind/layout/default/header.md
will always be overridden even if it already exist?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you're right. I'm not sure how to prevent this from happening...since the use case doesn't consider running a conversion more than once / running it on an existing MarkBind site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for
site.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since conversion calls
init
first and this will generatesite.json
, I'm not sure if this check will workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if
init
is ran with-c
flag, we check forsite.json
first?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um how about just checking for the existence of
_markbind/layout/default/header.md
and not doing anything if it exist? This would be in line with how we deal withabout.md
, and our general policy of not touching existing files with our defaults for other kinds of files as well (remember thatmarkbind init
itself can also be run more than once).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
markbind init
definitely creates aheader.md
file, so this check would mean the top nav content will never be written toheader.md
.