Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use light grey for siteNav text #554

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Use light grey for siteNav text #554

merged 1 commit into from
Jan 10, 2019

Conversation

Xenonym
Copy link
Contributor

@Xenonym Xenonym commented Jan 5, 2019

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Enhancement to an existing feature

Resolves #542.

What is the rationale for this request?
We can have lighter coloured text for the site navigation sidebar to give more relative importance to the main text.

What changes did you make? (Give an overview)
Adjust the colorfor siteNav text to be #444444.

Testing instructions:

  1. Observe that in MarkBind documents with a navigation sidebar, the colour of the text is #444444.

@damithc
Copy link
Contributor

damithc commented Jan 6, 2019

A little bit lighter? See https://hexo.io/docs/ for an example.

@Xenonym
Copy link
Contributor Author

Xenonym commented Jan 6, 2019

@damithc actually, I based it off Hexo; #444444 is the color of .sidebar-link. We could use the built-in Bootstrap grey, which is #6c757d. Here's what that looks like:

Alternatively, we can do the middle ground of #565656 for better contrast:

@damithc
Copy link
Contributor

damithc commented Jan 6, 2019

@Chng-Zhi-Xuan what do you think?

@Chng-Zhi-Xuan
Copy link
Contributor

Chng-Zhi-Xuan commented Jan 6, 2019

Looks ok to me. If you would like some accent colour, we can keep the blue on the rotating arrow when it is active?

Edit: Forgot to mention #565656 strikes a good balance for pure white backgrounds, Am ok with #444444 as well.

Copy link
Contributor

@Chng-Zhi-Xuan Chng-Zhi-Xuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes, squash any excess commits and force push for final approval.

@yamgent yamgent added this to the v1.16.1 milestone Jan 9, 2019
@yamgent yamgent merged commit 6851661 into MarkBind:master Jan 10, 2019
@Xenonym Xenonym deleted the lighter-sitenav-text branch January 10, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

siteNav: use lighter color for text
4 participants